[
https://issues.apache.org/jira/browse/SCB-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542534#comment-16542534
] ASF GitHub Bot commented on SCB-744: ------------------------------------ codecov-io commented on issue #390: SCB-744 Wrong error code returned in Find API URL: https://github.com/apache/incubator-servicecomb-service-center/pull/390#issuecomment-404728382 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390?src=pr&el=h1) Report > Merging [#390](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/fc6664cc646c52a01b7934e3b20fa801510146f2?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `68%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #390 +/- ## ========================================== + Coverage 71.54% 71.69% +0.14% ========================================== Files 39 39 Lines 4126 4130 +4 ========================================== + Hits 2952 2961 +9 + Misses 1007 1002 -5 Partials 167 167 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.55% <100%> (ø)` | :arrow_up: | | [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `66.03% <33.33%> (-0.22%)` | :arrow_down: | | [server/service/util/dependency\_query.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3F1ZXJ5Lmdv) | `51.9% <50%> (ø)` | :arrow_up: | | [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `71.48% <90.9%> (+0.28%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `80.28% <0%> (-0.71%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.32% <0%> (-0.63%)` | :arrow_down: | | [server/service/notification/publisher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3B1Ymxpc2hlci5nbw==) | `95.65% <0%> (+4.34%)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `79.16% <0%> (+5.55%)` | :arrow_up: | | [server/service/notification/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2NvbW1vbi5nbw==) | `100% <0%> (+10%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390?src=pr&el=footer). Last update [fc6664c...791101a](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/390?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Wrong error code returned in Find API > ------------------------------------- > > Key: SCB-744 > URL: https://issues.apache.org/jira/browse/SCB-744 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
