[
https://issues.apache.org/jira/browse/SCB-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545980#comment-16545980
]
ASF GitHub Bot commented on SCB-728:
------------------------------------
WillemJiang commented on a change in pull request #810: [SCB-728]
Decrypt/signature and adjust form in edge
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/810#discussion_r202882714
##########
File path:
demo/demo-edge/edge-service/src/main/java/org/apache/servicecomb/demo/edge/service/encrypt/filter/EdgeSignatureResponseFilter.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.demo.edge.service.encrypt.filter;
+
+import java.nio.charset.StandardCharsets;
+
+import org.apache.servicecomb.common.rest.filter.HttpServerFilter;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.demo.edge.authentication.encrypt.Hcr;
+import org.apache.servicecomb.demo.edge.service.EdgeConst;
+import org.apache.servicecomb.demo.edge.service.encrypt.EncryptContext;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.hash.Hasher;
+import com.google.common.hash.Hashing;
+
+import io.vertx.core.buffer.Buffer;
+
+public class EdgeSignatureResponseFilter implements HttpServerFilter {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(EdgeSignatureResponseFilter.class);
+
+ @Override
+ public int getOrder() {
+ return 10000;
+ }
+
+ @Override
+ public Response afterReceiveRequest(Invocation invocation,
HttpServletRequestEx requestEx) {
+ return null;
+ }
+
+ @Override
+ public void beforeSendResponse(Invocation invocation, HttpServletResponseEx
responseEx) {
+ EncryptContext encryptContext = (EncryptContext)
invocation.getHandlerContext().get(EdgeConst.ENCRYPT_CONTEXT);
+ if (encryptContext == null) {
+ return;
+ }
+ Hcr hcr = encryptContext.getHcr();
+
+ // bad practice: it's better to set signature in response header
Review comment:
Is it a stand request or just some specific user requirement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add decrypt/signature/... to edge demo
> --------------------------------------
>
> Key: SCB-728
> URL: https://issues.apache.org/jira/browse/SCB-728
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
> 1.add "decrypt“ logic, decrypt field named "body" in form, generate new
> multiple fields to form by "body"
> 2.move "signature" to edge, and only signature for one operation
> 3.request with form-data or x-www-form-urlencoded, edge convert to json
> automatically
> 4.query userId by serviceToken, and put userId back to form
> 5.calc signature from response buffer, and add "signature" field to response
> body, eg:
> before: \{"k":"v"}
> after: \{"k":"v","signature":"xxxxx"}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
