[
https://issues.apache.org/jira/browse/SCB-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546858#comment-16546858
]
ASF GitHub Bot commented on SCB-708:
------------------------------------
yhs0092 commented on a change in pull request #815: [SCB-708] Aggregate simple
query params into object param in spring mvc style
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/815#discussion_r203092951
##########
File path:
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/utils/ParamUtils.java
##########
@@ -27,15 +27,14 @@
import org.springframework.core.DefaultParameterNameDiscoverer;
import org.springframework.core.MethodParameter;
-import com.fasterxml.jackson.databind.ser.std.MapProperty;
-
import io.swagger.converter.ModelConverters;
import io.swagger.models.Model;
import io.swagger.models.Swagger;
import io.swagger.models.parameters.AbstractSerializableParameter;
import io.swagger.models.parameters.BodyParameter;
import io.swagger.models.parameters.Parameter;
import io.swagger.models.properties.ArrayProperty;
+import io.swagger.models.properties.MapProperty;
Review comment:
In line 130，MapProperty is used for param type check. A wrong MapProperty is
imported before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support assembling query param into Object parameter(in Spring MVC developing
> style)
> ------------------------------------------------------------------------------------
>
> Key: SCB-708
> URL: https://issues.apache.org/jira/browse/SCB-708
> Project: Apache ServiceComb
> Issue Type: New Feature
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> In Spring Boot, user can define a REST operation with Object parameters, and
> there is no Annotation on the param like below:
> {code:java}
> @RequestMapping("/address")
> public String address(Address address)
> {code}
> {code:java}
> public class Address {
> String country;
> String city;
> }
> {code}
> Spring can assemble the query variable city and country into address, like
> /address?city=cc&country=co
> We need to support similar function.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
