[
https://issues.apache.org/jira/browse/SCB-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555024#comment-16555024
]
ASF GitHub Bot commented on SCB-767:
------------------------------------
wujimin closed pull request #827: [SCB-767]When using Response to return
multi-code message, handlers /filters given ClassCaseException
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/827
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
index 8d31fee2b..add91b435 100644
---
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
+++
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
@@ -68,6 +68,7 @@ public static void run() throws Exception {
testValidator(templateNew);
testClientTimeOut(templateNew);
testJaxRSDefaultValues(templateNew);
+ MultiErrorCodeServiceClient.runTest();
}
private static void testCompute(RestTemplate template) throws Exception {
diff --git
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/MultiErrorCodeServiceClient.java
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/MultiErrorCodeServiceClient.java
new file mode 100644
index 000000000..fb4851c10
--- /dev/null
+++
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/MultiErrorCodeServiceClient.java
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.demo.jaxrs.client;
+
+import javax.ws.rs.core.Response.Status;
+
+import org.apache.servicecomb.core.CseContext;
+import org.apache.servicecomb.demo.DemoConst;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.demo.multiErrorCode.MultiRequest;
+import org.apache.servicecomb.demo.multiErrorCode.MultiResponse200;
+import org.apache.servicecomb.demo.multiErrorCode.MultiResponse400;
+import org.apache.servicecomb.demo.multiErrorCode.MultiResponse500;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.client.RestTemplate;
+
+public class MultiErrorCodeServiceClient {
+ private static final String SERVER = "cse://jaxrs";
+
+ private static RestTemplate template = RestTemplateBuilder.create();
+
+ public static void runTest() {
+ for (String transport : DemoConst.transports) {
+
CseContext.getInstance().getConsumerProviderManager().setTransport("jaxrs",
transport);
+
+ testErrorCode();
+ testErrorCodeWithHeader();
+ testErrorCodeWithHeaderJAXRS();
+ }
+ }
+
+ private static void testErrorCode() {
+ MultiRequest request = new MultiRequest();
+
+ request.setCode(200);
+ ResponseEntity<MultiResponse200> result = template
+ .postForEntity(SERVER + "/MultiErrorCodeService/errorCode", request,
MultiResponse200.class);
+ TestMgr.check(result.getStatusCode(), 200);
+ TestMgr.check(result.getBody().getMessage(), "success result");
+
+ request.setCode(400);
+ MultiResponse400 t400 = null;
+ try {
+ template.postForEntity(SERVER + "/MultiErrorCodeService/errorCode",
request, MultiResponse400.class);
+ } catch (InvocationException e) {
+ t400 = (MultiResponse400) e.getErrorData();
+ }
+ TestMgr.check(t400.getCode(), 400);
+ TestMgr.check(t400.getMessage(), "bad request");
+
+ request.setCode(500);
+ MultiResponse500 t500 = null;
+ try {
+ template.postForEntity(SERVER + "/MultiErrorCodeService/errorCode",
request, MultiResponse400.class);
+ } catch (InvocationException e) {
+ t500 = (MultiResponse500) e.getErrorData();
+ }
+ TestMgr.check(t500.getCode(), 500);
+ TestMgr.check(t500.getMessage(), "internal error");
+ }
+
+ private static void testErrorCodeWithHeader() {
+ MultiRequest request = new MultiRequest();
+
+ request.setCode(200);
+ ResponseEntity<MultiResponse200> result = template
+ .postForEntity(SERVER + "/MultiErrorCodeService/errorCodeWithHeader",
request, MultiResponse200.class);
+ TestMgr.check(result.getStatusCode(), 200);
+ TestMgr.check(result.getBody().getMessage(), "success result");
+ TestMgr.check(result.getBody().getCode(), 200);
+ TestMgr.check(result.getHeaders().getFirst("x-code"), 200);
+
+ request.setCode(400);
+ MultiResponse400 t400 = null;
+ try {
+ template.postForEntity(SERVER +
"/MultiErrorCodeService/errorCodeWithHeader", request, MultiResponse400.class);
+ } catch (InvocationException e) {
+ t400 = (MultiResponse400) e.getErrorData();
+ TestMgr.check(e.getStatus().getStatusCode(),
Status.BAD_REQUEST.getStatusCode());
+ }
+ TestMgr.check(t400.getCode(), 400);
+ TestMgr.check(t400.getMessage(), "bad request");
+
+ request.setCode(500);
+ MultiResponse500 t500 = null;
+ try {
+ template.postForEntity(SERVER +
"/MultiErrorCodeService/errorCodeWithHeader", request, MultiResponse400.class);
+ } catch (InvocationException e) {
+ t500 = (MultiResponse500) e.getErrorData();
+ TestMgr.check(e.getStatus().getStatusCode(),
Status.INTERNAL_SERVER_ERROR.getStatusCode());
+ }
+ TestMgr.check(t500.getCode(), 500);
+ TestMgr.check(t500.getMessage(), "internal error");
+ }
+
+ private static void testErrorCodeWithHeaderJAXRS() {
+ MultiRequest request = new MultiRequest();
+
+ request.setCode(200);
+ ResponseEntity<MultiResponse200> result = template
+ .postForEntity(SERVER +
"/MultiErrorCodeService/errorCodeWithHeaderJAXRS", request,
MultiResponse200.class);
+ TestMgr.check(result.getStatusCode(), 200);
+ TestMgr.check(result.getBody().getMessage(), "success result");
+ TestMgr.check(result.getBody().getCode(), 200);
+ TestMgr.check(result.getHeaders().getFirst("x-code"), 200);
+
+ request.setCode(400);
+ MultiResponse400 t400 = null;
+ try {
+ template
+ .postForEntity(SERVER +
"/MultiErrorCodeService/errorCodeWithHeaderJAXRS", request,
MultiResponse400.class);
+ } catch (InvocationException e) {
+ t400 = (MultiResponse400) e.getErrorData();
+ TestMgr.check(e.getStatus().getStatusCode(),
Status.BAD_REQUEST.getStatusCode());
+ }
+ TestMgr.check(t400.getCode(), 400);
+ TestMgr.check(t400.getMessage(), "bad request");
+
+ request.setCode(500);
+ MultiResponse500 t500 = null;
+ try {
+ template
+ .postForEntity(SERVER +
"/MultiErrorCodeService/errorCodeWithHeaderJAXRS", request,
MultiResponse400.class);
+ } catch (InvocationException e) {
+ t500 = (MultiResponse500) e.getErrorData();
+ TestMgr.check(e.getStatus().getStatusCode(),
Status.INTERNAL_SERVER_ERROR.getStatusCode());
+ }
+ TestMgr.check(t500.getCode(), 500);
+ TestMgr.check(t500.getMessage(), "internal error");
+ }
+}
diff --git a/demo/demo-jaxrs/jaxrs-server/pom.xml
b/demo/demo-jaxrs/jaxrs-server/pom.xml
index 6f8c2327c..d6dab7dd5 100644
--- a/demo/demo-jaxrs/jaxrs-server/pom.xml
+++ b/demo/demo-jaxrs/jaxrs-server/pom.xml
@@ -36,6 +36,12 @@
<groupId>org.apache.servicecomb</groupId>
<artifactId>provider-jaxrs</artifactId>
</dependency>
+ <!-- This is a demo, user can choose any implementation you want -->
+ <dependency>
+ <groupId>org.glassfish.jersey.core</groupId>
+ <artifactId>jersey-client</artifactId>
+ <version>2.25.1</version>
+ </dependency>
<dependency>
<groupId>org.apache.servicecomb</groupId>
<artifactId>swagger-invocation-validator</artifactId>
diff --git
a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/multiErrorCode/MultiErrorCodeService.java
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/multiErrorCode/MultiErrorCodeService.java
new file mode 100644
index 000000000..e99b75fa7
--- /dev/null
+++
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/multiErrorCode/MultiErrorCodeService.java
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.jaxrs.server.multiErrorCode;
+
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.core.Response.Status;
+
+import org.apache.servicecomb.demo.multiErrorCode.MultiRequest;
+import org.apache.servicecomb.demo.multiErrorCode.MultiResponse200;
+import org.apache.servicecomb.demo.multiErrorCode.MultiResponse400;
+import org.apache.servicecomb.demo.multiErrorCode.MultiResponse500;
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.apache.servicecomb.swagger.extend.annotations.ResponseHeaders;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+import io.swagger.annotations.ResponseHeader;
+
+@RestSchema(schemaId = "MultiErrorCodeService")
+@Path("MultiErrorCodeService")
+public class MultiErrorCodeService {
+ @Path("/errorCode")
+ @POST
+ @ApiResponses({
+ @ApiResponse(code = 200, response = MultiResponse200.class, message =
""),
+ @ApiResponse(code = 400, response = MultiResponse400.class, message =
""),
+ @ApiResponse(code = 500, response = MultiResponse500.class, message =
"")})
+ public MultiResponse200 errorCode(MultiRequest request) {
+ if (request.getCode() == 400) {
+ MultiResponse400 r = new MultiResponse400();
+ r.setCode(400);
+ r.setMessage("bad request");
+ throw new
InvocationException(javax.ws.rs.core.Response.Status.BAD_REQUEST, r);
+ } else if (request.getCode() == 500) {
+ MultiResponse500 r = new MultiResponse500();
+ r.setCode(500);
+ r.setMessage("internal error");
+ throw new
InvocationException(javax.ws.rs.core.Response.Status.INTERNAL_SERVER_ERROR, r);
+ } else {
+ MultiResponse200 r = new MultiResponse200();
+ r.setCode(200);
+ r.setMessage("success result");
+ return r;
+ }
+ }
+
+ @Path("/errorCodeWithHeader")
+ @POST
+ @ApiResponses({
+ @ApiResponse(code = 200, response = MultiResponse200.class, message =
""),
+ @ApiResponse(code = 400, response = MultiResponse400.class, message =
""),
+ @ApiResponse(code = 500, response = MultiResponse500.class, message =
"")})
+ @ResponseHeaders({@ResponseHeader(name = "x-code", response = String.class)})
+ public Response errorCodeWithHeader(MultiRequest request) {
+ Response response = new Response();
+ if (request.getCode() == 400) {
+ MultiResponse400 r = new MultiResponse400();
+ r.setCode(400);
+ r.setMessage("bad request");
+ response.setStatus(Status.BAD_REQUEST);
+ // If got many types for different status code, we can only using
InvocationException for failed error code like 400-500.
+ // The result for Failed Family(e.g. 400-500), can not set return value
as target type directly or will give exception.
+ response.setResult(new InvocationException(Status.BAD_REQUEST, r));
+ response.getHeaders().addHeader("x-code", "400");
+ } else if (request.getCode() == 500) {
+ MultiResponse500 r = new MultiResponse500();
+ r.setCode(500);
+ r.setMessage("internal error");
+ response.setStatus(Status.INTERNAL_SERVER_ERROR);
+ response.setResult(new InvocationException(Status.INTERNAL_SERVER_ERROR,
r));
+ response.getHeaders().addHeader("x-code", "500");
+ } else {
+ MultiResponse200 r = new MultiResponse200();
+ r.setCode(200);
+ r.setMessage("success result");
+ response.setStatus(Status.OK);
+ // If error code is OK family(like 200), we can use the target type.
+ response.setResult(r);
+ response.getHeaders().addHeader("x-code", "200");
+ }
+ return response;
+ }
+
+ // using JAX-RS providers, users need to add dependencies for
implementations, see pom for an example.
+ @Path("/errorCodeWithHeaderJAXRS")
+ @POST
+ @ApiResponses({
+ @ApiResponse(code = 200, response = MultiResponse200.class, message =
""),
+ @ApiResponse(code = 400, response = MultiResponse400.class, message =
""),
+ @ApiResponse(code = 500, response = MultiResponse500.class, message =
"")})
+ @ResponseHeaders({@ResponseHeader(name = "x-code", response = String.class)})
+ public javax.ws.rs.core.Response errorCodeWithHeaderJAXRS(MultiRequest
request) {
+ javax.ws.rs.core.Response response;
+ if (request.getCode() == 400) {
+ MultiResponse400 r = new MultiResponse400();
+ r.setCode(400);
+ r.setMessage("bad request");
+ // If got many types for different status code, we can only using
InvocationException for failed error code like 400-500.
+ // The result for Failed Family(e.g. 400-500), can not set return value
as target type directly or will give exception.
+ response = javax.ws.rs.core.Response.status(Status.BAD_REQUEST)
+ .entity(new InvocationException(Status.BAD_REQUEST, r))
+ .header("x-code", "400")
+ .build();
+ } else if (request.getCode() == 500) {
+ MultiResponse500 r = new MultiResponse500();
+ r.setCode(500);
+ r.setMessage("internal error");
+ response = javax.ws.rs.core.Response.status(Status.INTERNAL_SERVER_ERROR)
+ .entity(new InvocationException(Status.INTERNAL_SERVER_ERROR, r))
+ .header("x-code", "500")
+ .build();
+ } else {
+ MultiResponse200 r = new MultiResponse200();
+ r.setCode(200);
+ r.setMessage("success result");
+ // If error code is OK family(like 200), we can use the target type.
+ response = javax.ws.rs.core.Response.status(Status.OK)
+ .entity(r)
+ .header("x-code", "200")
+ .build();
+ }
+ return response;
+ }
+}
diff --git
a/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiRequest.java
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiRequest.java
new file mode 100644
index 000000000..738355a12
--- /dev/null
+++
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiRequest.java
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.multiErrorCode;
+
+public class MultiRequest{
+ private String message;
+
+ private int code;
+
+ public String getMessage() {
+ return message;
+ }
+
+ public void setMessage(String message) {
+ this.message = message;
+ }
+
+ public int getCode() {
+ return code;
+ }
+
+ public void setCode(int code) {
+ this.code = code;
+ }
+}
diff --git
a/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse200.java
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse200.java
new file mode 100644
index 000000000..34f60c7e5
--- /dev/null
+++
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse200.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.multiErrorCode;
+
+public class MultiResponse200 {
+ private String message;
+
+ private int code;
+
+ private long t200;
+
+ public String getMessage() {
+ return message;
+ }
+
+ public void setMessage(String message) {
+ this.message = message;
+ }
+
+ public int getCode() {
+ return code;
+ }
+
+ public void setCode(int code) {
+ this.code = code;
+ }
+
+ public long getT200() {
+ return t200;
+ }
+
+ public void setT200(long t200) {
+ this.t200 = t200;
+ }
+}
diff --git
a/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse400.java
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse400.java
new file mode 100644
index 000000000..af27dc1e4
--- /dev/null
+++
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse400.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.multiErrorCode;
+
+public class MultiResponse400 {
+ private String message;
+
+ private int code;
+
+ private long t400;
+
+ public String getMessage() {
+ return message;
+ }
+
+ public void setMessage(String message) {
+ this.message = message;
+ }
+
+ public int getCode() {
+ return code;
+ }
+
+ public void setCode(int code) {
+ this.code = code;
+ }
+
+ public long getT400() {
+ return t400;
+ }
+
+ public void setT400(long t400) {
+ this.t400 = t400;
+ }
+}
diff --git
a/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse500.java
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse500.java
new file mode 100644
index 000000000..379d1ba2a
--- /dev/null
+++
b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/multiErrorCode/MultiResponse500.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.multiErrorCode;
+
+public class MultiResponse500 {
+ private String message;
+
+ private int code;
+
+ private long t500;
+
+ public String getMessage() {
+ return message;
+ }
+
+ public void setMessage(String message) {
+ this.message = message;
+ }
+
+ public int getCode() {
+ return code;
+ }
+
+ public void setCode(int code) {
+ this.code = code;
+ }
+
+ public long getT500() {
+ return t500;
+ }
+
+ public void setT500(long t500) {
+ this.t500 = t500;
+ }
+}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> When using Response to return multi-code message, handlers / filters given
> ClassCaseException
> ---------------------------------------------------------------------------------------------
>
> Key: SCB-767
> URL: https://issues.apache.org/jira/browse/SCB-767
> Project: Apache ServiceComb
> Issue Type: Bug
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Error code 400， 500 etc. takes as error. But the object result is not
> throwable. So got class cast exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
