[
https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565148#comment-16565148
]
ASF GitHub Bot commented on SCB-792:
------------------------------------
asifdxtreme commented on a change in pull request #407: SCB-792 More abundant
metrics information
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206841318
##########
File path: server/metric/common.go
##########
@@ -16,17 +16,44 @@
*/
package metric
-import "time"
+import (
+ "github.com/astaxie/beego"
+ "net"
+ "sync"
+ "time"
+)
const (
- defaultMetricsSize = 100
- collectInterval = 5 * time.Second
+ collectInterval = 5 * time.Second
Review comment:
Suggestion : Can we make this interval time configurable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> More abundant metrics information
> ---------------------------------
>
> Key: SCB-792
> URL: https://issues.apache.org/jira/browse/SCB-792
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
