[
https://issues.apache.org/jira/browse/SCB-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569654#comment-16569654
]
ASF GitHub Bot commented on SCB-688:
------------------------------------
liubao68 commented on a change in pull request #852: [SCB-688] vertx rest
server not accept too many connection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/852#discussion_r207760722
##########
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/ClientEvent.java
##########
@@ -20,21 +20,35 @@
/**
* Notice: this event will raised in vertx eventloop thread, so do not run any
block code
*/
-public class ClientClosedEvent {
+public class ClientEvent {
private final String address;
+ private final EventType eventType;
+
+ private final ServerType serverType;
+
private final int totalConnectedCount;
public String getAddress() {
return address;
}
+ public EventType getEventType() {
+ return eventType;
+ }
+
+ public ServerType getServerType() {
+ return serverType;
+ }
+
public int getTotalConnectedCount() {
return totalConnectedCount;
}
- public ClientClosedEvent(String address, int totalConnectedCount) {
+ public ClientEvent(String address, EventType eventType, ServerType
serverType, int totalConnectedCount) {
Review comment:
I'd prefer ClientEvent -> ConnectionEvent & ServerType -> TransportType, how
do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> vertx rest server not accept too many connection
> ------------------------------------------------
>
> Key: SCB-688
> URL: https://issues.apache.org/jira/browse/SCB-688
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: yangyongzheng
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
