[
https://issues.apache.org/jira/browse/SCB-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569662#comment-16569662
]
ASF GitHub Bot commented on SCB-799:
------------------------------------
liubao68 commented on a change in pull request #854: [SCB-799] Fix ut in
different environment
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/854#discussion_r207761098
##########
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/Config.java
##########
@@ -37,15 +37,15 @@
public static final String PROVIDER_ENABLED =
"servicecomb.flowcontrol.Provider.qps.enabled";
- public static final Config INSTANCE = new Config();
+ public static Config INSTANCE = new Config();
private final DynamicBooleanProperty consumerEanbled =
DynamicPropertyFactory.getInstance().getBooleanProperty(CONSUMER_ENABLED, true);
private final DynamicBooleanProperty providerEanbled =
DynamicPropertyFactory.getInstance().getBooleanProperty(PROVIDER_ENABLED, true);
- private Config() {
+ public Config() {
Review comment:
Maybe we'd better to make it visible to package and used for test only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> fix problem about "mvn install" in ubuntu
> -----------------------------------------
>
> Key: SCB-799
> URL: https://issues.apache.org/jira/browse/SCB-799
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
