[
https://issues.apache.org/jira/browse/SCB-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574170#comment-16574170
]
ASF GitHub Bot commented on SCB-690:
------------------------------------
liubao68 commented on a change in pull request #862: [SCB-690] add check if
connection is still connected before execute invocation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/862#discussion_r208783189
##########
File path:
transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##########
@@ -95,17 +99,21 @@ public void start(Future<Void> startFuture) throws
Exception {
HttpServer httpServer = createHttpServer();
httpServer.requestHandler(mainRouter::accept);
httpServer.connectionHandler(connection -> {
+ String address = connection.remoteAddress().toString();
Review comment:
How about client established multi connections to this server?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> when producer invocation prepare to run in executor, make sure not
> disconnect/ not time out
> -------------------------------------------------------------------------------------------
>
> Key: SCB-690
> URL: https://issues.apache.org/jira/browse/SCB-690
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: yangyongzheng
> Priority: Major
>
> vertx rest and highway not control producer timeout
>
> note: if already running, then could do nothing, just let it go till finished.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
