[
https://issues.apache.org/jira/browse/SCB-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577922#comment-16577922
]
ASF GitHub Bot commented on SCB-831:
------------------------------------
coveralls commented on issue #249: SCB-831 fix test case failed on windows
environment in LoadBalancedClusterMessageSenderTest
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/249#issuecomment-412433595
[](https://coveralls.io/builds/18451115)
Coverage increased (+0.2%) to 94.32% when pulling
**e1a5ff6658ed740fe57f1a8d4af08678750eaf53 on zhengyangyong:SCB-831** into
**37c483b4d3c9807c7ee2c72a325250666bb7b662 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Saga UT failed at LoadBalancedClusterMessageSenderTest on Windows environment
> -----------------------------------------------------------------------------
>
> Key: SCB-831
> URL: https://issues.apache.org/jira/browse/SCB-831
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
> Affects Versions: saga-0.2.0
> Environment: Windows 7 or Windows Server 2008 R2
> Reporter: yangyongzheng
> Priority: Major
>
> UT will failed at :
> LoadBalancedClusterMessageSenderTest.stopSendingWhenClusterIsDown
> It seems this assert
> await().atMost(2, SECONDS).until(new Callable<Boolean>() {
> @Override
> public Boolean call() throws Exception {
> return connected.get(8080).size() == 2 || connected.get(8090).size()
> == 2;
> }
> });
> The connected size will only be 1 not 2
> I had found out that GrpcCompensateStreamObserver don't trigger onError when
> simulate connection closed in this case so LoadBalancedClusterMessageSender
> can't take PushBackReconnectRunnable from pendingTasks in order to reconnect
> server, then the connected count will be only 1, then test case failed
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
