[
https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579188#comment-16579188
]
ASF GitHub Bot commented on SCB-612:
------------------------------------
wujimin commented on a change in pull request #861: [SCB-612]delete useless
MicroserviceMetaManager
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r209818549
##########
File path:
core/src/main/java/org/apache/servicecomb/core/definition/loader/SchemaListenerManager.java
##########
@@ -74,12 +67,22 @@ public void notifySchemaListener(List<SchemaMeta>
schemaMetaList) {
}
public SchemaMeta ensureFindSchemaMeta(String microserviceName, String
schemaId) {
- MicroserviceMeta microserviceMeta =
microserviceMetaManager.ensureFindValue(microserviceName);
+ if
(!RegistryUtils.getMicroservice().getServiceName().equals(microserviceName)) {
Review comment:
if throw exception, then just remove "microserviceName" parameter is better.
so:
1.just log and return
2.deprecated the method, and invoke another method without parameter
"microserviceName"
(old one will be deleted in future version)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> delete useless MicroserviceMetaManager
> --------------------------------------
>
> Key: SCB-612
> URL: https://issues.apache.org/jira/browse/SCB-612
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: wujimin
> Priority: Major
> Labels: newbie
>
> in previous versions, consumer and producer microserviceMeta all managed by
> MicroserviceMetaManager
>
> currently:
> all consumer MicroserviceMeta managed by AppManager
> only producer MicroserviceMeta remains in MicroserviceMetaManager, there is
> only one MicroserviceMeta instance, so MicroserviceMetaManager is useless
> just move producer MicroserviceMeta to SCBEngine is enough
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
