[
https://issues.apache.org/jira/browse/SCB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579711#comment-16579711
]
ASF GitHub Bot commented on SCB-833:
------------------------------------
liubao68 closed pull request #870: [SCB-833] IOException do not trigger retry
mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/870
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
index 118fe0c45..ea23aca6c 100644
---
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
+++
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
@@ -16,7 +16,6 @@
*/
package org.apache.servicecomb.loadbalance;
-import java.io.IOException;
import java.net.ConnectException;
import java.net.SocketTimeoutException;
import java.util.Collection;
@@ -51,7 +50,7 @@ public RetryHandler createRetryHandler(String retryName,
String microservice) {
Configuration.INSTANCE.getRetryOnSame(microservice),
Configuration.INSTANCE.getRetryOnNext(microservice), true) {
private List<Class<? extends Throwable>> retriable = Lists
- .newArrayList(new Class[] {ConnectException.class,
SocketTimeoutException.class, IOException.class});
+ .newArrayList(new Class[] {ConnectException.class,
SocketTimeoutException.class});
@Override
public boolean isRetriableException(Throwable e, boolean sameServer) {
diff --git
a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestExtensionsManager.java
b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestExtensionsManager.java
index c0070cabb..69c4a1eca 100644
---
a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestExtensionsManager.java
+++
b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestExtensionsManager.java
@@ -123,6 +123,6 @@ public void testRuleClassName() {
Assert.assertTrue(retryHandler.isRetriableException(new
ConnectException(), true));
Assert.assertTrue(retryHandler.isRetriableException(new
SocketTimeoutException(), false));
Assert.assertTrue(retryHandler.isRetriableException(new
SocketTimeoutException(), true));
- Assert.assertTrue(retryHandler.isRetriableException(new IOException(),
true));
+ Assert.assertFalse(retryHandler.isRetriableException(new IOException(),
true));
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide a retry mechanism to meet upgrade no interrupt
> ------------------------------------------------------
>
> Key: SCB-833
> URL: https://issues.apache.org/jira/browse/SCB-833
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
> Assignee: liubao
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> see https://bbs.huaweicloud.com/blogs/72a312f09c8911e89fc57ca23e93a89f
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
