[
https://issues.apache.org/jira/browse/SCB-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582157#comment-16582157
]
ASF GitHub Bot commented on SCB-846:
------------------------------------
wujimin commented on a change in pull request #872: [SCB-846]
ConfigCenterClient log much in the pull mode
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/872#discussion_r210511956
##########
File path:
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ParseConfigUtils.java
##########
@@ -74,14 +74,23 @@ public void initWithUpdateHandler(UpdateHandler
updateHandler) {
public void refreshConfigItems(Map<String, Map<String, Object>> remoteItems)
{
try {
configLock.lock();
+ String oldRevision = currentVersionInfo;
+ boolean newVersion = false;
currentVersionInfo =
remoteItems.getOrDefault("revision", new
HashMap<>()).getOrDefault("version", "default").toString();
//make sure the currentVersionInfo != ""
currentVersionInfo = currentVersionInfo.equals("") ? "default" :
currentVersionInfo;
- remoteItems.remove("revision");//the key revision is not the config
setting
+ if (remoteItems.containsKey("revision")) {
Review comment:
why?
from the code, if newVersion is false, still invoked doRefreshItems
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [SCB-846] ConfigCenterClient log too much in the pull mode
> ----------------------------------------------------------
>
> Key: SCB-846
> URL: https://issues.apache.org/jira/browse/SCB-846
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: 何一乐
> Assignee: 何一乐
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
