[
https://issues.apache.org/jira/browse/SCB-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585030#comment-16585030
]
ASF GitHub Bot commented on SCB-745:
------------------------------------
imlijinting opened a new pull request #254: [SCB-745] Refactoring
LoadBalancedClusterMessageSender.
URL: https://github.com/apache/incubator-servicecomb-saga/pull/254
* MessageDeserializer and MessageSerializer were added as part of
AlphaClusterConfig.
* Decoupled GrpcClientMessageSender from
LoadBalancedClusterMessageSender#ErrorHandlerFactory.
* Drop ErrorHandlerFactory class.
* Managing MessageSender life cycle using MessageSenderManager, instead of
using PushBackReconnectRunnable.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> RetrySender should not throw exception when go the saga start event.
> --------------------------------------------------------------------
>
> Key: SCB-745
> URL: https://issues.apache.org/jira/browse/SCB-745
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
> Affects Versions: saga-0.2.0
> Reporter: Willem Jiang
> Assignee: justin li
> Priority: Major
> Fix For: saga-0.3.0
>
>
> If Alpha Server Fail when book-service do send event, the book-service will
> fail forever.
> It turns out the RetrySender should not throw exception when go the saga
> start event.
> You can find more information here.
> https://github.com/apache/incubator-servicecomb-saga/issues/217
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
