[
https://issues.apache.org/jira/browse/SCB-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587453#comment-16587453
]
ASF GitHub Bot commented on SCB-860:
------------------------------------
yhs0092 opened a new pull request #880: [SCB-860] Optimize microservice
register process, abort registry when query microservice id fails
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/880
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
See details in [SCB-860](https://issues.apache.org/jira/browse/SCB-860)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optimize microservice register process, abort registry when query
> microservice id fails
> ---------------------------------------------------------------------------------------
>
> Key: SCB-860
> URL: https://issues.apache.org/jira/browse/SCB-860
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Minor
>
> Currently if the microservice id query fails or microservice does not exist,
> the sc client will return null, and MicroserviceRegisterTask cannot
> distinguish these situation. As a result, even though query fails,
> MicroserviceRegisterTask will go on to the next logic, which will cause
> unnecessary net work load.
> We need to make sc client return more detailed microservice id query result,
> and abort registry process when query fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
