[
https://issues.apache.org/jira/browse/SCB-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589540#comment-16589540
]
ASF GitHub Bot commented on SCB-206:
------------------------------------
liubao68 commented on a change in pull request #882: [SCB-206] Support setting
produces and consumes by @Api
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/882#discussion_r212156900
##########
File path:
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/annotation/ApiProcessor.java
##########
@@ -17,18 +17,69 @@
package org.apache.servicecomb.swagger.generator.core.processor.annotation;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
import org.apache.servicecomb.swagger.generator.core.ClassAnnotationProcessor;
import org.apache.servicecomb.swagger.generator.core.SwaggerGenerator;
import org.springframework.util.StringUtils;
import io.swagger.annotations.Api;
+import io.swagger.models.Swagger;
Review comment:
Can you add an integration test for this feature?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support @Api to specify produces and consumes
> ---------------------------------------------
>
> Key: SCB-206
> URL: https://issues.apache.org/jira/browse/SCB-206
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Trivial
> Fix For: java-chassis-1.1.0
>
>
> At present, ServiceComb only process the `tags` of
> io.swagger.annotations.Api. If user specify produces and consumes in `@Api`,
> nothing will happen.
> The support to these two fields should be added if necessary. The hierarchy
> relationship of `SwaggerDefinition`, `Api`, `ApiOperation` is that `Api`
> overrides `SwaggerDefinition`, `ApiOperation` overrides `Api`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
