[
https://issues.apache.org/jira/browse/SCB-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593514#comment-16593514
]
ASF GitHub Bot commented on SCB-865:
------------------------------------
WillemJiang commented on a change in pull request #268: SCB-865 Implement
reaction of the event in Alpha Server
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/268#discussion_r212942967
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/tcc/callback/TccCallbackEngine.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.alpha.server.tcc.callback;
+
+import java.lang.invoke.MethodHandles;
+import
org.apache.servicecomb.saga.alpha.server.tcc.registry.TransactionEventRegistry;
+import org.apache.servicecomb.saga.alpha.server.tcc.event.ParticipatedEvent;
+import org.apache.servicecomb.saga.common.TransactionStatus;
+import
org.apache.servicecomb.saga.pack.contract.grpc.GrpcTccTransactionEndedEvent;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class TccCallbackEngine implements CallbackEngine {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ private final OmegaCallbackWrapper omegaCallbackWrapper;
+
+ public TccCallbackEngine(OmegaCallbackWrapper omegaCallbackWrapper) {
+ this.omegaCallbackWrapper = omegaCallbackWrapper;
+ }
+
+ @Override
+ public boolean execute(GrpcTccTransactionEndedEvent request) {
+ boolean result = true;
+ for (ParticipatedEvent event :
TransactionEventRegistry.retrieve(request.getGlobalTxId())) {
+ try {
+ omegaCallbackWrapper.invoke(event,
TransactionStatus.valueOf(request.getStatus()));
+ } catch (Exception ex) {
+ logError(event, ex);
+ result = false;
Review comment:
We need to check if all the participated omega's callback is called. You
code just exit if there is an exception is thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring the Omega Interceptors
> ----------------------------------
>
> Key: SCB-865
> URL: https://issues.apache.org/jira/browse/SCB-865
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Willem Jiang
> Priority: Major
>
> Current Omega transaction has two saga interceptors, one is for SagaStart,
> the other is for Compensable. As these two interceptor has different context
> to deal with, they are not supposed to share the same interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
