[
https://issues.apache.org/jira/browse/SCB-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595763#comment-16595763
]
ASF GitHub Bot commented on SCB-874:
------------------------------------
WillemJiang commented on a change in pull request #276: SCB-874:saga dubbo demo
insert sql and readme optimization
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/276#discussion_r213509701
##########
File path: saga-demo/saga-dubbo-demo/README.md
##########
@@ -15,10 +15,88 @@ You will need:
[alpha_server]:
https://github.com/apache/incubator-servicecomb-saga/tree/master/alpha
## Running Demo
-```bash
-$ mvn clean install -DskipTests -Pdocker
-$ ./saga-dubbo-demo.sh up
+1. run the following command to create docker images in saga project root
folder.
+ ```
+ mvn clean install -DskipTests -Pdocker -Pdemo
+ ```
+2. Enter the saga dubbo demo directory and give permissions to script
+ ```
+ cd ./saga-demo/saga-dubbo-demo
+ chmod +x saga-dubbo-demo.sh
Review comment:
It can be fixed by add the +x in the sh file. We don't need to instruct the
user to do this thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> saga dubbo demo insert sql and readme optimization
> --------------------------------------------------
>
> Key: SCB-874
> URL: https://issues.apache.org/jira/browse/SCB-874
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Affects Versions: saga-0.3.0
> Reporter: FuChenGeng
> Assignee: FuChenGeng
> Priority: Minor
> Labels: documentation, patch
> Fix For: saga-0.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> services in saga dubbo demo can not restart because of the sql primary key.
> and some document improvement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
