[
https://issues.apache.org/jira/browse/SCB-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597199#comment-16597199
]
ASF GitHub Bot commented on SCB-880:
------------------------------------
wujimin commented on a change in pull request #886: [SCB-880]Give an option to
query parameter convert empty to null
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/886#discussion_r213949298
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java
##########
@@ -44,6 +46,13 @@ public Object getValue(HttpServletRequest request) throws
Exception {
value = request.getParameterValues(paramPath);
} else {
value = request.getParameter(paramPath);
+ // make some old systems happy
+ if (DynamicPropertyFactory.getInstance()
Review comment:
every time invoke DynamicPropertyFactory.getInstance().getBooleanProperty,
will:
1.create a instance of DynamicBooleanProperty
2.three times map search at least
and this value almost not changed, better to cache it and update by callback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Give an option to query parameter convert empty to null
> -------------------------------------------------------
>
> Key: SCB-880
> URL: https://issues.apache.org/jira/browse/SCB-880
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Java-Chassis
> Reporter: liubao
> Assignee: liubao
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> Some old system parse query like [http://host/path/a=&b=22] and value of a is
> null. But Servicecomb is empty. We need give an option to make these system
> happy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
