[
https://issues.apache.org/jira/browse/SCB-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598068#comment-16598068
]
ASF GitHub Bot commented on SCB-859:
------------------------------------
WillemJiang commented on a change in pull request #885: [SCB-859] Generate
traceid
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/885#discussion_r214217261
##########
File path: core/src/main/java/org/apache/servicecomb/core/Invocation.java
##########
@@ -188,11 +209,46 @@ public String getMicroserviceQualifiedName() {
return operationMeta.getMicroserviceQualifiedName();
}
+ protected void initTraceId() {
+ for (TraceIdGenerator traceIdGenerator : TRACE_ID_GENERATORS) {
+ initTraceId(traceIdGenerator);
Review comment:
If there are lots of transaction Id generators, they may override the
transaction id each other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate traceId when create invocation for consumer/producer/edge
> ------------------------------------------------------------------
>
> Key: SCB-859
> URL: https://issues.apache.org/jira/browse/SCB-859
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> current generate traceId is a filter, and only for producer, it's not enough.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
