[
https://issues.apache.org/jira/browse/SCB-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598074#comment-16598074
]
ASF GitHub Bot commented on SCB-876:
------------------------------------
WillemJiang commented on a change in pull request #283: SCB-876 Implement of
Omega TCC coordinate command callback and refactor
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/283#discussion_r214212153
##########
File path:
omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/MethodCheckingCallback.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.omega.transaction.spring;
+
+import java.lang.invoke.MethodHandles;
+import java.lang.reflect.Method;
+import org.apache.servicecomb.saga.omega.context.CallbackContext;
+import org.apache.servicecomb.saga.omega.transaction.OmegaException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.util.ReflectionUtils.MethodCallback;
+
+public abstract class MethodCheckingCallback implements MethodCallback {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ private final Object bean;
+
+ private final CallbackContext callbackContext;
+
+ private final String callbackType;
Review comment:
It‘s better to be enum type, in this way we can get control of the
callbackType.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Confirm and Cancel invocation support of Omega
> ----------------------------------------------
>
> Key: SCB-876
> URL: https://issues.apache.org/jira/browse/SCB-876
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Saga
> Reporter: Willem Jiang
> Assignee: cherrylzhao
> Priority: Major
> Fix For: saga-0.3.0
>
>
> Omega need to support to invoke the Confirm or Cancel method when it gets the
> commend from the alpha. Current we don't support to pass the invocation
> context (method parameter around). We just need which method need to called.
> The Confirm and Cancel method should be checked before Omega is started.
> Please take the Saga Omega code as an reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
