[
https://issues.apache.org/jira/browse/SCB-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601897#comment-16601897
]
ASF GitHub Bot commented on SCB-864:
------------------------------------
KomachiSion commented on a change in pull request #286: [SCB-864] support
multiple parameters for each sql
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/286#discussion_r214613610
##########
File path:
saga-core/src/main/java/org/apache/servicecomb/saga/core/SQLOperation.java
##########
@@ -23,18 +23,18 @@
public class SQLOperation implements Operation {
private final String sql;
- private final List<String> params;
+ private final List<List<Object>> params;
- public SQLOperation(String sql, List<String> params) {
+ public SQLOperation(String sql, List<List<Object>> params) {
Review comment:
params may be Integer, Date. so I think Object may be more suitable than
String?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support to call SQL component in saga-core
> ------------------------------------------
>
> Key: SCB-864
> URL: https://issues.apache.org/jira/browse/SCB-864
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
> Reporter: Willem Jiang
> Priority: Major
>
> Sharding-Sphere is planning to use Sage command executor as it's distributed
> transaction coordinator. We need to introduce new SQL command for
> Sharding-Sphere to use.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
