[
https://issues.apache.org/jira/browse/SCB-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602814#comment-16602814
]
ASF GitHub Bot commented on SCB-886:
------------------------------------
yhs0092 commented on a change in pull request #888: [SCB-886] Fix path param
encode decode problem
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/888#discussion_r214846789
##########
File path:
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/base/TestDataTypeJaxrs.java
##########
@@ -255,4 +252,19 @@ public void testDefault_rt() {
Integer result = restTemplate.getForObject(urlPrefix, Integer.class);
assertEquals((int) result, 100);
}
+
+ @Test
+ public void spaceCharEncode_intf() {
Review comment:
The tests have been moved into `ParamCodecSchema` and `TestParamCodec`.
Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Path param is not encoded and decoded correctly
> -----------------------------------------------
>
> Key: SCB-886
> URL: https://issues.apache.org/jira/browse/SCB-886
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
>
> We find some problems:
> # for provider side, "%20" and "+" are both decoded to space char " ". But
> for path param, only "%20" should be decoded to space, and "+" should not be
> converted. See discussion in [QueryStringDecoder does not decode correctly
> path part with '+' (plus) sign in
> it|https://github.com/netty/netty/issues/6745]
> # for consumer side, currently path param is not encoded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
