[
https://issues.apache.org/jira/browse/SCB-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605160#comment-16605160
]
ASF GitHub Bot commented on SCB-889:
------------------------------------
liubao68 closed pull request #890: [SCB-889] add SCBEngine reference to
BootEvent
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/890
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/src/main/java/org/apache/servicecomb/core/BootListener.java
b/core/src/main/java/org/apache/servicecomb/core/BootListener.java
index 848ccdc31..b273467db 100644
--- a/core/src/main/java/org/apache/servicecomb/core/BootListener.java
+++ b/core/src/main/java/org/apache/servicecomb/core/BootListener.java
@@ -34,8 +34,18 @@
}
class BootEvent {
+ private SCBEngine scbEngine;
+
private EventType eventType;
+ public SCBEngine getScbEngine() {
+ return scbEngine;
+ }
+
+ public void setScbEngine(SCBEngine scbEngine) {
+ this.scbEngine = scbEngine;
+ }
+
public EventType getEventType() {
return eventType;
}
diff --git a/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
b/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
index dcd877f40..c52fb6438 100644
--- a/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
+++ b/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
@@ -90,6 +90,10 @@ public static SCBEngine getInstance() {
return INSTANCE;
}
+ public EventBus getEventBus() {
+ return eventBus;
+ }
+
public void setProducerProviderManager(
ProducerProviderManager producerProviderManager) {
this.producerProviderManager = producerProviderManager;
@@ -128,6 +132,7 @@ public void setBootListenerList(Collection<BootListener>
bootListenerList) {
protected void triggerEvent(EventType eventType) {
BootEvent event = new BootEvent();
+ event.setScbEngine(this);
event.setEventType(eventType);
for (BootListener listener : bootListenerList) {
@@ -137,6 +142,7 @@ protected void triggerEvent(EventType eventType) {
protected void safeTriggerEvent(EventType eventType) {
BootEvent event = new BootEvent();
+ event.setScbEngine(this);
event.setEventType(eventType);
for (BootListener listener : bootListenerList) {
diff --git a/core/src/test/java/org/apache/servicecomb/core/TestSCBEngine.java
b/core/src/test/java/org/apache/servicecomb/core/TestSCBEngine.java
index ea6371b46..5d8035963 100644
--- a/core/src/test/java/org/apache/servicecomb/core/TestSCBEngine.java
+++ b/core/src/test/java/org/apache/servicecomb/core/TestSCBEngine.java
@@ -21,7 +21,10 @@
import java.util.Arrays;
import java.util.concurrent.atomic.AtomicBoolean;
+import javax.xml.ws.Holder;
+
import org.apache.servicecomb.config.ConfigUtil;
+import org.apache.servicecomb.core.BootListener.EventType;
import org.apache.servicecomb.core.definition.loader.SchemaListenerManager;
import org.apache.servicecomb.core.provider.consumer.ConsumerProviderManager;
import org.apache.servicecomb.core.provider.consumer.ReferenceConfig;
@@ -155,4 +158,14 @@ public void setBootListenerList(@Mocked BootListener
beanListener, @Mocked BootL
Assert.assertThat(engine.getBootListenerList(),
Matchers.contains(spiListener, beanListener));
}
+
+ @Test
+ public void bootEvent_refEngine() {
+ Holder<SCBEngine> eventEngine = new Holder<>();
+ SCBEngine engine = new SCBEngine();
+ engine.setBootListenerList(Arrays.asList(event -> eventEngine.value =
event.getScbEngine()));
+ engine.triggerEvent(EventType.AFTER_REGISTRY);
+
+ Assert.assertNotNull(eventEngine.value);
+ }
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> add SCBEngine reference to BootEvent
> ------------------------------------
>
> Key: SCB-889
> URL: https://issues.apache.org/jira/browse/SCB-889
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
