[
https://issues.apache.org/jira/browse/SCB-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608493#comment-16608493
]
ASF GitHub Bot commented on SCB-901:
------------------------------------
codecov-io edited a comment on issue #439: SCB-901 Making service registration
api idempotent
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/439#issuecomment-419726353
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439?src=pr&el=h1)
Report
> Merging
[#439](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/1fe6a338470584e4ff8925e53beff68d44e77b70?src=pr&el=desc)
will **increase** coverage by `0.03%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 59.75% 59.78% +0.03%
==========================================
Files 149 149
Lines 13147 13165 +18
==========================================
+ Hits 7856 7871 +15
- Misses 4718 4721 +3
Partials 573 573
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=)
| `86.57% <100%> (+0.56%)` | :arrow_up: |
|
[server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv)
| `71.45% <86.2%> (-0.58%)` | :arrow_down: |
|
[server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv)
| `73.33% <0%> (-0.34%)` | :arrow_down: |
|
[pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==)
| `74.52% <0%> (+0.94%)` | :arrow_up: |
|
[server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=)
| `84.21% <0%> (+2.63%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439?src=pr&el=footer).
Last update
[1fe6a33...787b7cb](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/439?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Making service registration api idempotent
> ------------------------------------------
>
> Key: SCB-901
> URL: https://issues.apache.org/jira/browse/SCB-901
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
