[ 
https://issues.apache.org/jira/browse/SCB-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611669#comment-16611669
 ] 

ASF GitHub Bot commented on SCB-902:
------------------------------------

codecov-io commented on issue #440:  SCB-902 Support service discovery by 
Service Mesh 
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/440#issuecomment-420530900
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=h1)
 Report
   > Merging 
[#440](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/e24e73eddb66aed71653c5f7845e5d3053f783a9?src=pr&el=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `63.63%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #440      +/-   ##
   ==========================================
   - Coverage   59.79%   59.75%   -0.05%     
   ==========================================
     Files         149      149              
     Lines       13165    13169       +4     
   ==========================================
   - Hits         7872     7869       -3     
   - Misses       4721     4726       +5     
   - Partials      572      574       +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=)
 | `64.28% <0%> (-0.78%)` | :arrow_down: |
   | 
[server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=)
 | `68.21% <66.66%> (-0.85%)` | :arrow_down: |
   | 
[server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=)
 | `81.57% <0%> (-2.64%)` | :arrow_down: |
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `70.16% <0%> (-0.41%)` | :arrow_down: |
   | 
[server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=)
 | `86.76% <0%> (ø)` | :arrow_up: |
   | 
[server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==)
 | `84.51% <0%> (+0.64%)` | :arrow_up: |
   | 
[pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==)
 | `84.37% <0%> (+3.12%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=footer).
 Last update 
[e24e73e...099ba5d](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Support service discovery by Service Mesh
> -----------------------------------------
>
>                 Key: SCB-902
>                 URL: https://issues.apache.org/jira/browse/SCB-902
>             Project: Apache ServiceComb
>          Issue Type: New Feature
>          Components: Service-Center
>            Reporter: little-cui
>            Assignee: little-cui
>            Priority: Major
>             Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to