[
https://issues.apache.org/jira/browse/SCB-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617142#comment-16617142
]
ASF GitHub Bot commented on SCB-905:
------------------------------------
yhs0092 opened a new pull request #909: [SCB-905] GlobalRestFailureHandler
handle InvocationException properly
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/909
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Request connection is hang up when request path contains illegal string
> -----------------------------------------------------------------------
>
> Key: SCB-905
> URL: https://issues.apache.org/jira/browse/SCB-905
> Project: Apache ServiceComb
> Issue Type: Bug
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
>
> When provider receives a request that contains illegal path params like
> "%%E", an Exception
> java.lang.NumberFormatException: For input string: "%E"
> is thrown and no response is sent. On consumer side it seems like that the
> request connection is hang up until the request timed out.
> The root cause is that there is no failure handler to handle the
> NumberFormatException. As a result, the request process is interrupted and no
> response is returned.
> Usually it only happens in EdgeService because for
> Router.routeWithRegex(String) the % encoded string is decoded like above,
> while for Router.route() the path is not processed in such way. In
> EdgeService, routeWithRegex() is usually used, and in normal provide, we use
> route() instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
