[
https://issues.apache.org/jira/browse/SCB-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623263#comment-16623263
] ASF GitHub Bot commented on SCB-927: ------------------------------------ codecov-io edited a comment on issue #445: SCB-927 The latest Lager is not compatible URL: https://github.com/apache/incubator-servicecomb-service-center/pull/445#issuecomment-423075953 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr&el=h1) Report > Merging [#445](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3404f76e89342c8291d4e18eea63a183e0afe567?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `87.5%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #445 +/- ## ========================================= - Coverage 59.74% 59.7% -0.05% ========================================= Files 149 149 Lines 13167 13174 +7 ========================================= - Hits 7867 7865 -2 - Misses 4729 4737 +8 - Partials 571 572 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/dependency\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3V0aWwuZ28=) | `51.21% <100%> (+0.29%)` | :arrow_up: | | [pkg/log/logger.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `95.74% <100%> (ø)` | :arrow_up: | | [pkg/log/zap.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-cGtnL2xvZy96YXAuZ28=) | `89.42% <66.66%> (+2.5%)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `69.01% <0%> (-9.86%)` | :arrow_down: | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `61.29% <0%> (-5.38%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.26% <0%> (-0.06%)` | :arrow_down: | | [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `71.4% <0%> (-0.06%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.33% <0%> (+0.12%)` | :arrow_up: | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `70.68% <0%> (+0.52%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr&el=footer). Last update [3404f76...559a22f](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The latest Lager is not compatible > ---------------------------------- > > Key: SCB-927 > URL: https://issues.apache.org/jira/browse/SCB-927 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
