[
https://issues.apache.org/jira/browse/SCB-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627361#comment-16627361
] ASF GitHub Bot commented on SCB-938: ------------------------------------ codecov-io edited a comment on issue #450: SCB-938 Should check self presevation max ttl URL: https://github.com/apache/incubator-servicecomb-service-center/pull/450#issuecomment-424199820 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=h1) Report > Merging [#450](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/4c2d47e2b3048959e858bfb8a974b06144464ad4?src=pr&el=desc) will **decrease** coverage by `0.18%`. > The diff coverage is `88.23%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #450 +/- ## ========================================== - Coverage 59.98% 59.79% -0.19% ========================================== Files 149 149 Lines 13182 13183 +1 ========================================== - Hits 7907 7883 -24 - Misses 4703 4735 +32 + Partials 572 565 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/core/backend/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jb21tb24uZ28=) | `100% <ø> (ø)` | :arrow_up: | | [server/core/backend/defer\_instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kZWZlcl9pbnN0YW5jZS5nbw==) | `85.86% <88.23%> (+0.15%)` | :arrow_up: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `15.11% <0%> (-29.07%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.76% <0%> (-0.19%)` | :arrow_down: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `61.19% <0%> (+1.49%)` | :arrow_up: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `84.21% <0%> (+2.63%)` | :arrow_up: | | [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `81.81% <0%> (+9.09%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=footer). Last update [4c2d47e...0bdac2c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Should check self presevation max ttl > ------------------------------------- > > Key: SCB-938 > URL: https://issues.apache.org/jira/browse/SCB-938 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
