[
https://issues.apache.org/jira/browse/SCB-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633412#comment-16633412
]
ASF GitHub Bot commented on SCB-942:
------------------------------------
wujimin commented on a change in pull request #935: [SCB-942]Choose the highest
priority from all implementation classes
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/935#discussion_r221463949
##########
File path:
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/SPIServiceUtils.java
##########
@@ -149,7 +149,7 @@ private SPIServiceUtils() {
List<T> services = getOrLoadSortedService(serviceType);
return (IMPL) services
.stream()
- .filter(service -> service.getClass().equals(implType))
+ .filter(service -> implType.isAssignableFrom(service.getClass()))
Review comment:
design purpose is equal
why do this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> choose the highest priority from all implementation classes
> -----------------------------------------------------------
>
> Key: SCB-942
> URL: https://issues.apache.org/jira/browse/SCB-942
> Project: Apache ServiceComb
> Issue Type: Task
> Reporter: laijianbin
> Assignee: laijianbin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
