[ https://issues.apache.org/jira/browse/SCB-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641255#comment-16641255 ]
ASF GitHub Bot commented on SCB-950: ------------------------------------ heyile commented on a change in pull request #944: [SCB-950] modify consumer producer metrics and add edge metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#discussion_r223234373 ########## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/statistics/MeterDetailStatisticsModel.java ########## @@ -0,0 +1,204 @@ +package org.apache.servicecomb.metrics.core.publish.statistics; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; + +import org.apache.servicecomb.metrics.core.meter.invocation.MeterInvocationConst; +import org.apache.servicecomb.metrics.core.publish.model.invocation.OperationPerf; +import org.apache.servicecomb.metrics.core.publish.model.invocation.PerfInfo; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class MeterDetailStatisticsModel { Review comment: Oh, I think I can make it better, maybe I can change the structure when load the data at bellow // group by transport for (MeasurementNode transportNode : node.getChildren().values()) { // group by operation for (MeasurementNode operationNode : transportNode.getChildren().values()) { // group by status for (MeasurementNode statusNode : operationNode.getChildren().values()) { //groups : transport -> statusCode -> operation -> pref PublishUtils.addOperationPerfGroups(groups, transportNode.getName(), operationNode.getName(), statusNode); } } } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-950] modify consumer producer metrics and add edge metrics > ---------------------------------------------------------------- > > Key: SCB-950 > URL: https://issues.apache.org/jira/browse/SCB-950 > Project: Apache ServiceComb > Issue Type: Improvement > Reporter: 何一乐 > Assignee: 何一乐 > Priority: Major > > the info in the old metics is not enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)