[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646111#comment-16646111
]
ASF GitHub Bot commented on SCB-837:
------------------------------------
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r224357351
##########
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
##########
@@ -83,13 +82,10 @@ public void dequeueRequest(DefaultClientEndpointMetric
endpointMetric, Object ta
@Override
public void endpointConnected(DefaultClientEndpointMetric endpointMetric,
DefaultHttpSocketMetric socketMetric) {
- //only http1.1 will invoke this method, just make a check
- if (endpointMetric != null) {
- if (endpointMetric != socketMetric.getEndpointMetric()) {
- socketMetric.setEndpointMetric(endpointMetric);
- }
- endpointMetric.onConnect();
- }
+ // as http2 client will not invoke this method, the endpointMetric info
will lost.
+ // you can get more details from
https://github.com/eclipse-vertx/vert.x/issues/2660
+ // hence, we will set endpointMetric info in the method
connected(SocketAddress remoteAddress, String remoteName)
+ endpointMetric.onConnect();
Review comment:
move to "connected", so that will depend if vertx fixed the bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> make http2 production ready
> ---------------------------
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: 何一乐
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
