[
https://issues.apache.org/jira/browse/SCB-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654865#comment-16654865
]
ASF GitHub Bot commented on SCB-718:
------------------------------------
liubao68 commented on a change in pull request #937: [SCB-718]If auto discovery
failed, will cause a dead cycle
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/937#discussion_r226215162
##########
File path:
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/TestIpPortManager.java
##########
@@ -122,6 +122,7 @@ public void testGetAvailableAddress(@Injectable
ServiceRegistryConfig config,
};
manager.initAutoDiscovery();
+ manager.setAutoDiscoveryInited(true);
Review comment:
这个测试用例是不是有问题？需要尝试构造initAutoDiscovery失败和成功。
每次initAutoDiscovery，然后显示的设置setAutoDiscoveryInited(true)，相当于执行initAutoDiscovery没啥意义了。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> If auto discovery failed , will cause a dead cycle
> --------------------------------------------------
>
> Key: SCB-718
> URL: https://issues.apache.org/jira/browse/SCB-718
> Project: Apache ServiceComb
> Issue Type: Task
> Reporter: laijianbin
> Assignee: laijianbin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
