[
https://issues.apache.org/jira/browse/SCB-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664819#comment-16664819
]
ASF GitHub Bot commented on SCB-985:
------------------------------------
liubao68 commented on a change in pull request #969: [SCB-985] Add
spring-boot2-starter-discovery
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/969#discussion_r228432266
##########
File path: java-chassis-dependencies-springboot2/pom.xml
##########
@@ -37,10 +37,11 @@
<argLine>-Dfile.encoding=UTF-8</argLine>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <spring.version>5.0.4.RELEASE</spring.version>
- <spring.boot.version>2.0.0.RELEASE</spring.boot.version>
- <spring.data.version>2.0.5.RELEASE</spring.data.version>
+ <spring.version>5.0.6.RELEASE</spring.version>
+ <spring.boot.version>2.0.3.RELEASE</spring.boot.version>
+ <spring.data.version>2.0.3.RELEASE</spring.data.version>
<spring.session.version>2.0.3.RELEASE</spring.session.version>
+ <spring-cloud.version>Finchley.RELEASE</spring-cloud.version>
</properties>
<dependencyManagement>
Review comment:
```
<dependencies>
<dependency> <dependency>
<groupId>org.springframework.boot</groupId>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter</artifactId>
<artifactId>spring-boot-starter</artifactId>
<version>${spring.boot.version}</version>
<version>${spring.boot.version}</version>
<type>pom</type> <type>pom</type>
<scope>import</scope> <scope>import</scope>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.springframework.boot</groupId>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
<artifactId>spring-boot-starter-web</artifactId>
<version>${spring.boot.version}</version>
<version>${spring.boot.version}</version>
<type>pom</type> <type>pom</type>
<scope>import</scope> <scope>import</scope>
</dependency> </dependency>
````
Can be deleted if using spring boot dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add springboot2-starter-discovery
> ---------------------------------
>
> Key: SCB-985
> URL: https://issues.apache.org/jira/browse/SCB-985
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.1.0
> Reporter: Yang Bo
> Assignee: Yang Bo
> Priority: Major
>
> Copied springboot-starter-discovery to spritnboot2. Removed test code and
> updated some spring-boot and spring-cloud versions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
