[ 
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668006#comment-16668006
 ] 

ASF GitHub Bot commented on SCB-993:
------------------------------------

little-cui closed pull request #474: SCB-993 span_test.go:151: Fatalf call has 
arguments but no formatting directives
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/plugin/pkg/tracing/buildin/span_test.go 
b/server/plugin/pkg/tracing/buildin/span_test.go
index c44ba2a2..fcf86679 100644
--- a/server/plugin/pkg/tracing/buildin/span_test.go
+++ b/server/plugin/pkg/tracing/buildin/span_test.go
@@ -148,19 +148,19 @@ func TestFromZipkinSpan(t *testing.T) {
        span := &zipkincore.Span{}
        err := json.Unmarshal(sample, &span)
        if err != nil {
-               t.Fatalf("TestFromZipkinSpan Unmarshal", err)
+               t.Fatalf("TestFromZipkinSpan Unmarshal, %v", err)
        }
        s := FromZipkinSpan(span)
        b, err := json.Marshal(s)
        if err != nil {
-               t.Fatalf("TestFromZipkinSpan Marshal", err)
+               t.Fatalf("TestFromZipkinSpan Marshal, %v", err)
        }
        fmt.Println(string(b))
 
        s = FromZipkinSpan(&zipkincore.Span{})
        b, err = json.Marshal(s)
        if err != nil {
-               t.Fatalf("TestFromZipkinSpan Marshal", err)
+               t.Fatalf("TestFromZipkinSpan Marshal, %v", err)
        }
        fmt.Println(string(b))
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bug fixes
> ---------
>
>                 Key: SCB-993
>                 URL: https://issues.apache.org/jira/browse/SCB-993
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Service-Center
>            Reporter: little-cui
>            Assignee: little-cui
>            Priority: Major
>             Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to