[ 
https://issues.apache.org/jira/browse/SCB-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677742#comment-16677742
 ] 

ASF GitHub Bot commented on SCB-979:
------------------------------------

liubao68 commented on a change in pull request #983: [SCB-979] add reminder log 
on the selection of SwaggerGeneratorContext
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/983#discussion_r231392835
 
 

 ##########
 File path: 
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/pojo/PojoSwaggerGeneratorContext.java
 ##########
 @@ -47,6 +53,16 @@ public int getOrder() {
 
   @Override
   public boolean canProcess(Class<?> cls) {
+    for (Annotation annotation : cls.getAnnotations()) {
+      // we check the annotations by class name to avoid importing extra 
dependencies in this module
+      if 
("javax.ws.rs.Path".equals(annotation.annotationType().getCanonicalName())
 
 Review comment:
   RestController maybe scaned for some scenario. But I think it is fine for 
this implementation, since it's only a info message 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add reminder log on the selection of SwaggerGeneratorContext
> ------------------------------------------------------------
>
>                 Key: SCB-979
>                 URL: https://issues.apache.org/jira/browse/SCB-979
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>            Reporter: YaoHaishi
>            Assignee: YaoHaishi
>            Priority: Major
>
> Add reminder log to show which SwaggerGeneratorContext is selected to 
> generate swagger schema, to indicate some potential problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to