[
https://issues.apache.org/jira/browse/SCB-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682868#comment-16682868
]
ASF GitHub Bot commented on SCB-1017:
-------------------------------------
wujimin commented on a change in pull request #987: [SCB-1017]add os cpu net
info in the metrics with linux os
URL:
https://github.com/apache/servicecomb-java-chassis/pull/987#discussion_r232487203
##########
File path:
foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/spectator/CpuNode.java
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.foundation.metrics.publish.spectator;
+
+import java.text.NumberFormat;
+
+public class CpuNode {
+
+ private static CpuNode INSTANCE = new CpuNode();
Review comment:
why need a global instance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [SCB-1017] add os cpu net info in the metrics with linux os
> ------------------------------------------------------------
>
> Key: SCB-1017
> URL: https://issues.apache.org/jira/browse/SCB-1017
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: 何一乐
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
