[ 
https://issues.apache.org/jira/browse/SCB-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685410#comment-16685410
 ] 

ASF GitHub Bot commented on SCB-1015:
-------------------------------------

codecov-io commented on issue #488: SCB-1015 Support the forth microservice 
version number registration
URL: 
https://github.com/apache/servicecomb-service-center/pull/488#issuecomment-438319857
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/488?src=pr&el=h1)
 Report
   > Merging 
[#488](https://codecov.io/gh/apache/servicecomb-service-center/pull/488?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/c3f06f1b40f8e3cb2f4fa60bcdf02e447e3aba40?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/488?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #488   +/-   ##
   =======================================
     Coverage   60.35%   60.35%           
   =======================================
     Files         159      159           
     Lines       13534    13534           
   =======================================
     Hits         8169     8169           
     Misses       4787     4787           
     Partials      578      578
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/488?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/versionrule.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC92ZXJzaW9ucnVsZS5nbw==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==)
 | `81.25% <0%> (-3.13%)` | :arrow_down: |
   | 
[pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==)
 | `73.58% <0%> (-0.95%)` | :arrow_down: |
   | 
[server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=)
 | `67.61% <0%> (-0.2%)` | :arrow_down: |
   | 
[server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv)
 | `57.78% <0%> (-0.16%)` | :arrow_down: |
   | 
[server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv)
 | `53.47% <0%> (+0.26%)` | :arrow_up: |
   | 
[pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=)
 | `34.28% <0%> (+0.57%)` | :arrow_up: |
   | 
[scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==)
 | `96.15% <0%> (+1.28%)` | :arrow_up: |
   | 
[server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/488/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==)
 | `65.38% <0%> (+3.84%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/488?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/488?src=pr&el=footer).
 Last update 
[c3f06f1...2d324cf](https://codecov.io/gh/apache/servicecomb-service-center/pull/488?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support the forth microservice version number registration
> ----------------------------------------------------------
>
>                 Key: SCB-1015
>                 URL: https://issues.apache.org/jira/browse/SCB-1015
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Service-Center
>            Reporter: little-cui
>            Assignee: little-cui
>            Priority: Major
>             Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to