[
https://issues.apache.org/jira/browse/SCB-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686012#comment-16686012
]
ASF GitHub Bot commented on SCB-986:
------------------------------------
yangbor commented on a change in pull request #990: [SCB-986] Cache instances
result in CseDiscoveryClient
URL:
https://github.com/apache/servicecomb-java-chassis/pull/990#discussion_r233293815
##########
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseDiscoveryClient.java
##########
@@ -44,24 +51,55 @@ public String description() {
@Override
public List<ServiceInstance> getInstances(final String serviceId) {
+ class InstanceDiscoveryFilter implements DiscoveryFilter {
Review comment:
Will move to a separate class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServerInstances can be cached in spring-boot2-starter-discovery
> ---------------------------------------------------------------
>
> Key: SCB-986
> URL: https://issues.apache.org/jira/browse/SCB-986
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.1.0
> Reporter: Yang Bo
> Assignee: Yang Bo
> Priority: Minor
>
> ServerInstances can be cached in spring-boot2-starter-discovery and
> spring-boot-starter-discovery
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
