[
https://issues.apache.org/jira/browse/SCB-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696407#comment-16696407
]
ASF GitHub Bot commented on SCB-1033:
-------------------------------------
asifdxtreme commented on a change in pull request #495: [SCB-1033] Update third
party licenses
URL:
https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235852180
##########
File path: scripts/release/LICENSE
##########
@@ -214,39 +214,40 @@ The following components are provided under the Apache
License Version 2.0.
See the respective project link for details.
================================================================
github.com/apache/thrift/lib/go/thrift
(3d556248a8b97310da49939195330691dfe9d9ad)
Review comment:
go mod is not updated and it uses lot of redudant repo which is actually not
used by Service-Center and that's the whole reason why the are not included in
the license, so for this release we prefer giving with glide.yaml and there is
definitely some amount of work needed to update the go mod file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update license for Service-Center
> ---------------------------------
>
> Key: SCB-1033
> URL: https://issues.apache.org/jira/browse/SCB-1033
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Service-Center
> Affects Versions: service-center-1.1.0
> Reporter: Yang Bo
> Assignee: Yang Bo
> Priority: Major
> Fix For: service-center-1.1.0
>
>
> Update license for Service-Center
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
