[
https://issues.apache.org/jira/browse/SCB-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697607#comment-16697607
]
ASF GitHub Bot commented on SCB-1043:
-------------------------------------
jeho0815 closed pull request #1006: [SCB-1043] fix bug: if safeSetInstances
throw an exception, the excep…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1006
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
index e85c51311..5e84b3c47 100644
---
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
+++
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
@@ -160,10 +160,10 @@ protected void
safeSetInstances(List<MicroserviceInstance> pulledInstances, Stri
setInstances(pulledInstances, rev);
validated = true;
} catch (Throwable e) {
- LOGGER.error("Failed to setInstances, appId={}, microserviceName={}.",
- getAppId(),
- getMicroserviceName(),
- e);
+ LOGGER.error(String.format("Failed to setInstances, AppId=%s,
MicroserviceName=%s.",
+ getAppId(),
+ getMicroserviceName()),
+ e);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MicroserviceVersions.safeSetInstances lost exception message
> ------------------------------------------------------------
>
> Key: SCB-1043
> URL: https://issues.apache.org/jira/browse/SCB-1043
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: jeho0815
> Assignee: jeho0815
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
