[
https://issues.apache.org/jira/browse/SCB-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706773#comment-16706773
]
ASF GitHub Bot commented on SCB-1054:
-------------------------------------
wujimin commented on a change in pull request #1016: [SCB-1054]when download
file, we should ignore consumer acceptType
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1016#discussion_r238161533
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/definition/RestOperationMeta.java
##########
@@ -105,6 +111,24 @@ public void init(OperationMeta operationMeta) {
setAbsolutePath(concatPath(swagger.getBasePath(),
operationMeta.getOperationPath()));
}
+ private void checkDownloadFile(Operation operation) {
Review comment:
1.change name to checkDownloadFileFlag
2.OperationMeta already collect ResponseMetas, just invoke
org.apache.servicecomb.swagger.invocation.response.ResponsesMeta#findResponseMeta,
and determined by
org.apache.servicecomb.swagger.invocation.response.ResponseMeta#javaType
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> when download file, we should ignore consumer acceptType
> --------------------------------------------------------
>
> Key: SCB-1054
> URL: https://issues.apache.org/jira/browse/SCB-1054
> Project: Apache ServiceComb
> Issue Type: Bug
> Reporter: 何一乐
> Assignee: 何一乐
> Priority: Critical
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
