[
https://issues.apache.org/jira/browse/SCB-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707167#comment-16707167
] ASF GitHub Bot commented on SCB-1059: ------------------------------------- codecov-io edited a comment on issue #505: SCB-1059 unexpected events publish if error occurs in previous list-watch loop URL: https://github.com/apache/servicecomb-service-center/pull/505#issuecomment-443663954 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=h1) Report > Merging [#505](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/307132ecc5e5d7995b79037f144208fe0ee4000a?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #505 +/- ## ========================================== + Coverage 59.31% 59.38% +0.07% ========================================== Files 166 166 Lines 13945 13944 -1 ========================================== + Hits 8271 8281 +10 + Misses 5088 5081 -7 + Partials 586 582 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/etcd/common.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY29tbW9uLmdv) | `100% <ø> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.36% <100%> (-0.12%)` | :arrow_down: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `63.1% <0%> (-0.98%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.36% <0%> (+0.18%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `96.15% <0%> (+1.28%)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <0%> (+9.85%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/505/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=footer). Last update [307132e...446cfc0](https://codecov.io/gh/apache/servicecomb-service-center/pull/505?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Bug fixes for v1.1.0 > -------------------- > > Key: SCB-1059 > URL: https://issues.apache.org/jira/browse/SCB-1059 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
