[
https://issues.apache.org/jira/browse/SCB-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708262#comment-16708262
]
ASF GitHub Bot commented on SCB-1063:
-------------------------------------
wujimin commented on a change in pull request #1021: [SCB-1063]Improve the time
cost when first time loading schema
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1021#discussion_r238541980
##########
File path:
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestVertxMetersInitializer.java
##########
@@ -92,6 +92,8 @@ public void start(Future<Void> startFuture) {
public void start(Future<Void> startFuture) {
HttpClient client = vertx.createHttpClient();
client.post(port, "127.0.0.1", "/").handler(resp -> {
+ resp.bodyHandler((buffer) -> {
Review comment:
startFuture.complete(); should move into the bodyHandler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve the time cost when first time loading schema
> ----------------------------------------------------
>
> Key: SCB-1063
> URL: https://issues.apache.org/jira/browse/SCB-1063
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> When first time to invoke a service, will download each schema and compile
> classes. Sometimes users got hundreds of schema, this will taken more than
> 30s and the first time invocation can get easily timeout.
>
> There are some improvements can be done:
> # loading and compile concurrently
> # fetch all schema in one invocation in service center.
>
> Notice:
> for edge, we should not cache all microservice schema, because some deleted
> service will not be used forever.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
