[ 
http://issues.apache.org/struts/browse/SHALE-249?page=comments#action_37945 ] 
            
James Mitchell commented on SHALE-249:
--------------------------------------

I don't understand why we can't just change it now.  If this were a key piece 
of the core library, sure, but this seems so minimal.  I'd wager that most 
people using this test library have their own base extension and therefore 
would only require a change in one file.  

I hate the Foo2 antipattern almost as much as I hate the FixForBug123Foo 
antipattern.

Just my $.02


> Add "throws Exception" to signatures of setUp() and tearDown() in 
> AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
>                 Key: SHALE-249
>                 URL: http://issues.apache.org/struts/browse/SHALE-249
>             Project: Shale
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Craig McClanahan
>
> (From a discussion on the user mailing list 
> <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/[EMAIL 
> PROTECTED]>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its 
> method signatures for setUp() and tearDown(), but this is not the case on 
> AbstractJsfTestCase.  Should be added for consistency.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to