[ http://issues.apache.org/struts/browse/SHALE-295?page=comments#action_38300 ] Mario Ivankovits commented on SHALE-295: ----------------------------------------
No, you misunderstood me. BTW: I am a hibernate etc. user, I know what it means to have tons of dependencies. (We have 91 of them - excluding our own app) Crag, did you look at the patch? Its a very simple one. You will see, that it uses explicitResources() (your method in LifeCycleListener2) to get a list of URLs of all explicitely configures faces-config.xml. Then, it simply gets the jarfile from the urlConnection. No additional scanning takes places. Its just, that shale-tiger not only recognizes META-INF/faces-config.xml as faces-app, but also those jars which contain a faces-config.xml, assumed, that the pointer to the faces-config.xml is configured through CONFIG_FILES configuration. This is code already running in LifeCycleListener2, now, its just reused for a different thing, there is no performance penalty. > collect web archives with explicit configured faces-config.xml pointing to > them > ------------------------------------------------------------------------------- > > Key: SHALE-295 > URL: http://issues.apache.org/struts/browse/SHALE-295 > Project: Shale > Issue Type: Improvement > Components: Tiger > Reporter: Mario Ivankovits > Attachments: explicit_jars.diff > > > The patch will also collect jars in WEB-INF/lib which have a faces-config.xml > pointing to them through the configuration javax.faces.CONFIG_FILES > That way, you no longer need to have a "marker" faces-config.xml in META-INF. > The patch is not heavily tested yet. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
