[ http://issues.apache.org/struts/browse/SHALE-351?page=comments#action_38980 ] Rahul Akolkar commented on SHALE-351: -------------------------------------
Since the DialogListener has never been part of a release, perhaps we can consider renaming it without leaving the package with deprecated classes in its first release itself? As a purely stylistic comment, AbstractDialogContextManagerListener is about as long of a classname as I personally prefer, but I have no better ideas ATM either, and it seems consistent, so lets just make progress. I take it this is assigned to you? In any case, I'd be happy to update the dialog-scxml module once the base is in place, if that helps. > Support events from DialogContextManager in addition to DialogContext > --------------------------------------------------------------------- > > Key: SHALE-351 > URL: http://issues.apache.org/struts/browse/SHALE-351 > Project: Shale > Issue Type: New Feature > Components: Dialog > Reporter: Craig McClanahan > > The current dialog APIs make it possible to register for fine grained events > on a particular DialogContext, but not on events from DialogContextManager. > In particular, it is not currently possible to be notified when a new > DialogContext instance is created via navigation. Address this by adding > eventing to DialogContextManager along the following lines: > * New DialogContextManagerListener interface with onCreate() and onRemove() > methods > * New AbstractDialogContextManager that implements the listener registration > stuff > (analogous to AbsractDialogContext for context level event) > * Modify the two DialogContextManager implementations to extend this new base > class > and to call the event firing methods at the right times > * Unit tests for all of the above (of course :-) > * For naming consistency, consider renaming DialogListener to > DialogContextListener > and associated ripple effects. We can minimize transition impacts on > current apps > by leaving a deprecated DialogListener interface that simply extends > DialogContextListener > (and so on). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
