[
https://issues.apache.org/struts/browse/SHALE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39658
]
Rahul Akolkar commented on SHALE-384:
-------------------------------------
Thanks a lot for taking time to review the sources. Couple of comments:
(a) The site.xml files is a result of my interpretation of the FAQ on
http://www.apache.org/legal/src-headers.html , primarily, these two:
<quote>
Does this policy apply to documentation files included in a release?
Yes.
Does this policy also apply to content displayed on our web sites?
No. Our web sites do not have an associated NOTICE file. Instead we may soon be
making the terms of such content explicit through a "Terms of Use" or "Legal
Information" link in the footer of web pages. At this point, no action is
required for Apache web sites.
</quote>
Most site sources in Shale have license headers since the content could be
interpreted as documentation, IMO. The site.xml files, OTOH, are purely site
artifacts so the second FAQ seemed to apply.
Having said that, I'm now in favor of adding these since this may come up
repeatedly.
(b) The clay test files seem to be added post SHALE-311 , and need to be fixed.
In your opinion, would it be OK to set this to a 1.0.5-SNAP fix version?
> Missing source file headers
> ---------------------------
>
> Key: SHALE-384
> URL: https://issues.apache.org/struts/browse/SHALE-384
> Project: Shale
> Issue Type: Bug
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: shale-missing-src-headers.patch
>
>
> Attaching a patch to add missing source file headers - mainly site.xml, but
> also three java tests in clay
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
