[
https://issues.apache.org/struts/browse/SHALE-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39724
]
Dennis Byrne commented on SHALE-382:
------------------------------------
Hi Craig,
Thanks for looking at this. Regarding your comments ...
Inside of testUniqueTagTestCase() the tagNames ArrayList is instantiated once
for each library. This allows the same tag name to exist across two different
libraries. If the List declaration was moved to the outer block, or if it were
a property of the class, the test would erroneously fail when validating
different libs with same named tags.
I think a dynamic TLD discovery mechanism would be useful, but some developers
may want to use this prior to or w/out building a jar or war.
> Abstract TestCase for testing TLDs
> ----------------------------------
>
> Key: SHALE-382
> URL: https://issues.apache.org/struts/browse/SHALE-382
> Project: Shale
> Issue Type: New Feature
> Components: Test
> Affects Versions: 1.0.4-SNAPSHOT
> Reporter: Dennis Byrne
> Priority: Minor
> Attachments: patch.txt
>
>
> Documentation is in the patch.
> I took Gary's advice on mailing list about eliminating the dependency on
> beanutils; I thought org.apache.shale.util.PropertyHelper would be a good
> place. However the Shale Test project *already* has a dependency on
> beanutils and it *doesn't* have a dependency on Shale Core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
