[
https://issues.apache.org/struts/browse/SHALE-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Craig McClanahan resolved SHALE-397.
------------------------------------
Resolution: Fixed
Add convenience methods for getting the DialogContextManager for this user, and
the active DialogContext (if any) for this request. Simplify both the internal
implementations and the test applications by using these calls.
(We should look at the same sort of simplification pattern in other modules
where we currently force the application developer to access our scoped
attributes via symbolic constants.)
> Add DialogContextHelper with static accessors to eliminate need to manipulate
> scoped attributes directly
> --------------------------------------------------------------------------------------------------------
>
> Key: SHALE-397
> URL: https://issues.apache.org/struts/browse/SHALE-397
> Project: Shale
> Issue Type: Improvement
> Affects Versions: 1.0.4, 1.1.0-SNAPSHOT
> Reporter: Craig McClanahan
> Assigned To: Craig McClanahan
> Fix For: 1.1.0-SNAPSHOT
>
>
> The current implementation of the dialog machinery in Shale occasionally
> requires the application to directly access scoped attributes via a symbolic
> constant string. Examples include accessing the current DialogContextManager
> instance, creating it if necessary. This is unnecessarily brittle, and
> restricts possible future improvements in the actual functionality.
> To replace this, create a DialogContextHelper class with static convenience
> methods that perform the same logic currently required of the application in
> these use cases, but abstracted away to simplify application logic and
> insulate it from future changes in the internal implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
