[
https://issues.apache.org/struts/browse/SHALE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39892
]
Rahul Akolkar commented on SHALE-393:
-------------------------------------
Yup, the RAT run is clean now, thanks. I have a couple of comments:
1) The patch contains numerous unrelated (to license headers) changes to the
web.xml, faces-config.xml and README for instance. They all seem useful, but
can you confirm that you intended to have those changes in the patch.
2) The POM inherits from struts-parent, which seems like oversight (I can
correct this one).
> License header update for Clay starter archetype
> ------------------------------------------------
>
> Key: SHALE-393
> URL: https://issues.apache.org/struts/browse/SHALE-393
> Project: Shale
> Issue Type: Improvement
> Components: Clay
> Affects Versions: 1.0.3
> Reporter: Hermod Opstvedt
> Assigned To: Rahul Akolkar
> Priority: Minor
> Attachments: ClayStarterArchetype.patch
>
>
> I have been through the files, and added/updated the license header. Could
> you run the tests again Rahul.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
